Skip to content

Rename ID property and more cleaning #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 26, 2025
Merged

Rename ID property and more cleaning #366

merged 9 commits into from
Jun 26, 2025

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented Jun 19, 2025 •
edited
Loading

Description

  • Remove id property from nodes:
    • The LLM generated ID that is only used to create relationships between node is renamed __tmp_internal_id and cleaned from the db after ingestion
    • That means that nodes are now allowed to have an id property (extracted from text or something else)
  • Add more pruning rules to discard nodes with empty label (empty means "", not null is already enforced by the pydantic model) and relationships with empty type (that causes failures later in the process since empty labels are not allowed)

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity:

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia requested a review from a team as a code owner June 19, 2025 15:39
@stellasia stellasia marked this pull request as draft June 23, 2025 13:01
@stellasia stellasia marked this pull request as ready for review June 24, 2025 14:59
NathalieCharbel
NathalieCharbel reviewed Jun 25, 2025
View reviewed changes
@stellasia stellasia merged commit ddc78ce into neo4j:main Jun 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathalieCharbel NathalieCharbel NathalieCharbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellasia @NathalieCharbel